implement testing_buildBlockV1 by macfarla · Pull Request #9838 · besu-eth/besu

macfarla · 2026-02-18T06:10:39Z

PR description

related to #9832 which also introduces GenericBlockCreator
RpcMethod.java — Added TESTING_BUILD_BLOCK_V1("testing_buildBlockV1")

Refs a proposed JSON-RPC method, it introduces a new namespace specifically for testing and a new method testing_buildBlockV1 - there is a go-ethereum PR and OpenRPC specs, etc.
ethereum/execution-apis#710
ethereum/execution-apis#747
ethereum/go-ethereum#33656

Thanks for sending a pull request! Have you done the following?

Checked out our contribution guidelines?
Considered documentation and added the doc-change-required label to this PR if updates are required.
Considered the changelog and included an update if required.
For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

spotless: ./gradlew spotlessApply
unit tests: ./gradlew build
acceptance tests: ./gradlew acceptanceTest
integration tests: ./gradlew integrationTest
reference tests: ./gradlew ethereum:referenceTests:referenceTests
hive tests: Engine or other RPCs modified?

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

.../org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/testing/TestingBuildBlockV1.java

jochem-brouwer · 2026-02-26T13:09:07Z

Hiya! Does this also include support for Glamsterdam / BALs?

I will point in a comment later on how you can test this testing (lol) RPC endpoint for this specific method!

matkt · 2026-02-27T07:13:30Z

Hiya! Does this also include support for Glamsterdam / BALs?

I will point in a comment later on how you can test this testing (lol) RPC endpoint for this specific method!

I see that the implementation is using EngineNewPayloadV4 so normally not.

Signed-off-by: Karim Taam <karim.t2am@gmail.com>

matkt · 2026-02-27T13:15:55Z

@jochem-brouwer updated the PR it should be compatible with BAL, I also tested locally for the moment with some tests

jochem-brouwer · 2026-02-27T14:33:51Z

This is great, we need this endpoint implemented with BAL/Glamsterdam support to start benchmarking BALs on top of state to get real numbers for BAL optimizations. For this we need one client to "fill" these tests (on top of state).

Thanks a lot for this! We'll check it out to see if we can fill these state tests with BALs

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

…testing-buildblockv1

Copilot

Pull request overview

Implements the proposed testing_buildBlockV1 JSON-RPC method under a new TESTING API group, along with supporting block-creation logic and spec/fixture tests.

Changes:

Adds testing_buildBlockV1 RPC method, parameter model, and API group wiring.
Introduces a specialized TestingBlockCreator and updates payload result ordering to include BAL/slot fields.
Adds integration/unit/spec tests plus chain-data fixtures for testing_buildBlockV1.

Reviewed changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
ethereum/blockcreation/src/test/java/org/hyperledger/besu/ethereum/blockcreation/TestingBuildBlockIntegrationTest.java	Adds block-creation integration tests validating BAL presence/absence and structure.
ethereum/blockcreation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/GenericBlockCreator.java	Updates file header copyright text.
ethereum/api/src/test/resources/org/hyperledger/besu/ethereum/api/jsonrpc/testing_buildBlockV1/chain-data/genesis.json	Adds genesis fixture for `testing_buildBlockV1` JSON-RPC by-spec tests.
ethereum/api/src/test/resources/org/hyperledger/besu/ethereum/api/jsonrpc/testing_buildBlockV1/*.json	Adds JSON-RPC by-spec request/response fixture cases for `testing_buildBlockV1`.
ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/testing/TestingBuildBlockV1Test.java	Adds unit tests for `TestingBuildBlockV1` validations and BAL encoding.
ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/bonsai/TestingBuildBlockJsonRpcHttpBySpecTest.java	Adds Bonsai HTTP by-spec test runner for the new method.
ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/AbstractJsonRpcHttpServiceTest.java	Enables `TESTING` RPC API and mocks extra mining/tx-selection dependencies.
ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/methods/TestingJsonRpcMethods.java	Introduces a new JSON-RPC API group for testing-only methods.
ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/methods/JsonRpcMethodsFactory.java	Wires `TestingJsonRpcMethods` into the methods factory.
ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/EngineGetPayloadResultV6.java	Adds explicit JSON property order for payload serialization including BAL/slot fields.
ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/parameters/TestingBuildBlockParameter.java	Adds request parameter model (parent hash, payload attributes, txs, extraData).
ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/testing/TestingBuildBlockV1.java	Implements the `testing_buildBlockV1` JSON-RPC method end-to-end.
ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/testing/TestingBlockCreator.java	Adds a testing-oriented block creator used by `testing_buildBlockV1`.
ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/RpcMethod.java	Registers new enum entry `TESTING_BUILD_BLOCK_V1`.

.../org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/testing/TestingBuildBlockV1.java

...rg/hyperledger/besu/ethereum/api/jsonrpc/internal/parameters/TestingBuildBlockParameter.java

...urces/org/hyperledger/besu/ethereum/api/jsonrpc/testing_buildBlockV1/chain-data/genesis.json

.../org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/testing/TestingBuildBlockV1.java

.../test/java/org/hyperledger/besu/ethereum/blockcreation/TestingBuildBlockIntegrationTest.java

Signed-off-by: Karim Taam <karim.t2am@gmail.com>

daniellehrner · 2026-03-05T10:35:59Z

.../org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/testing/TestingBlockCreator.java

@@ -0,0 +1,104 @@
+/*
+ * Copyright contributors to Hyperledger Besu.


We should drop the Hyperledger

daniellehrner · 2026-03-05T10:39:00Z

...ces/org/hyperledger/besu/ethereum/api/jsonrpc/testing_buildBlockV1/05_valid_parent_hash.json

There's a gap in the numbering in the filenames. We go from 4 to 6

I don't see a gap on my side.

https://github.com/hyperledger/besu/pull/9838/changes#diff-1fd58903497e93a7ced8eff02e7988a5f446a83c38b8156697c6646872432496

daniellehrner

I left 2 comments about dropping Hyperldeger from the copyright and a gap in the testfile numbering. The rest looks okay

Signed-off-by: Karim Taam <karim.t2am@gmail.com>

Signed-off-by: Karim Taam <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

Signed-off-by: Karim Taam <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: qu0b <stefan@starflinger.eu>

* TESTING api group allowed (#9946) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: qu0b <stefan@starflinger.eu> * implement testing_buildBlockV1 (#9838) Signed-off-by: Karim Taam <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: qu0b <stefan@starflinger.eu> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: qu0b <stefan@starflinger.eu> Signed-off-by: Karim Taam <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

implement testing_buildBlockV1

938058f

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

matkt reviewed Feb 26, 2026

View reviewed changes

.../org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/testing/TestingBuildBlockV1.java Outdated Show resolved Hide resolved

update RPC api and add tests

0d360a8

Signed-off-by: Karim Taam <karim.t2am@gmail.com>

macfarla mentioned this pull request Mar 3, 2026

TESTING rpc api group allowed #9946

Merged

10 tasks

macfarla self-assigned this Mar 4, 2026

macfarla added 2 commits March 5, 2026 07:20

merge

9537c1a

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

Merge branch 'testing-buildblockv1' of github.com:macfarla/besu into …

6ba4998

…testing-buildblockv1

macfarla marked this pull request as ready for review March 5, 2026 02:12

Copilot AI review requested due to automatic review settings March 5, 2026 02:12

macfarla added the RPC label Mar 5, 2026

Copilot AI reviewed Mar 5, 2026

View reviewed changes

matkt and others added 3 commits March 5, 2026 11:51

update implementation and json format

800ff5d

Signed-off-by: Karim Taam <karim.t2am@gmail.com>

Merge branch 'main' into testing-buildblockv1

def2a47

clean code and add request in response

01a90f7

Signed-off-by: Karim Taam <karim.t2am@gmail.com>

macfarla assigned daniellehrner and unassigned macfarla Mar 5, 2026

Merge branch 'main' into testing-buildblockv1

d76091d

daniellehrner reviewed Mar 5, 2026

View reviewed changes

daniellehrner requested changes Mar 5, 2026

View reviewed changes

matkt added 2 commits March 5, 2026 15:33

address review comments

e068cb9

Signed-off-by: Karim Taam <karim.t2am@gmail.com>

fix gap in tests

7dc5931

Signed-off-by: Karim Taam <karim.t2am@gmail.com>

daniellehrner approved these changes Mar 5, 2026

View reviewed changes

Merge branch 'main' into testing-buildblockv1

f88625f

matkt enabled auto-merge (squash) March 5, 2026 12:03

matkt merged commit 69d1c18 into besu-eth:main Mar 5, 2026
46 checks passed

macfarla deleted the testing-buildblockv1 branch March 5, 2026 21:50

qu0b pushed a commit to qu0b/besu that referenced this pull request Mar 16, 2026

implement testing_buildBlockV1 (besu-eth#9838)

a0fc1c7

Signed-off-by: Karim Taam <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

qu0b mentioned this pull request Mar 16, 2026

Cherry-pick testing_buildBlockV1 into bal-devnet-2 #10053

Merged

3 tasks

qu0b pushed a commit to qu0b/besu that referenced this pull request Mar 16, 2026

implement testing_buildBlockV1 (besu-eth#9838)

c536242

Signed-off-by: Karim Taam <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: qu0b <stefan@starflinger.eu>

		@@ -0,0 +1,104 @@
		/*
		* Copyright contributors to Hyperledger Besu.

Conversation

macfarla commented Feb 18, 2026

PR description

Thanks for sending a pull request! Have you done the following?

Locally, you can run these tests to catch failures early:

Uh oh!

Uh oh!

jochem-brouwer commented Feb 26, 2026

Uh oh!

matkt commented Feb 27, 2026

Uh oh!

matkt commented Feb 27, 2026

Uh oh!

jochem-brouwer commented Feb 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

daniellehrner Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

matkt Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

daniellehrner Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

matkt Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

matkt Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

daniellehrner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants